Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes and methods to RubyVM::InstructionSequence #2027

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

p-datadog
Copy link

At Datadog we use RubyVM::InstructionSequence objects (via line trace points) and we check types with steep. The type checking fails because none of the InstructionSequence methods are declared in the type file.

This PR adds the definitions with signatures taken from https://docs.ruby-lang.org/en/master/RubyVM/InstructionSequence.html.

Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@soutaro soutaro added this to the RBS 3.6 milestone Sep 30, 2024
@soutaro soutaro added this pull request to the merge queue Sep 30, 2024
Merged via the queue into ruby:master with commit 4e624d7 Sep 30, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants