Updated TracePoint #1943
Merged
Updated TracePoint #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampersand
force-pushed
the
swesterman/23-09-10/trace_point
branch
from
c2caf8c
to
c986477
Compare
sampersand
commented
Aug 1, 2024
| @@ -257,7 +257,7 @@ class TracePoint < Object | |||
| # C.foo | |||
| # end | |||
| # | |||
| def defined_class: () -> Module | |||
| def defined_class: () -> (Class | Module)? | |||
There was a problem hiding this comment.
Even though Class | Module is technically Module, i think this is much clearer for the end-user
soutaro
reviewed
Aug 5, 2024
| @@ -421,7 +421,7 @@ class TracePoint < Object | |||
| # Value from exception raised on the `:raise` event, or rescued on the `:rescue` | |||
| # event. | |||
| # | |||
| def raised_exception: () -> untyped | |||
| def raised_exception: () -> Exception | |||
There was a problem hiding this comment.
How is the case of other events than :raise nor :rescue?
Suggested change
| def raised_exception: () -> Exception | |
| def raised_exception: () -> Exception? |
There was a problem hiding this comment.
If you call raised_exception and there's no exception, it raises an error:
$ ruby -e 'TracePoint.trace(:line) { p _1.raised_exception }; p 1'
<internal:trace_point>:402:in `raised_exception': not supported by this event (RuntimeError)
from -e:1:in `block in <main>'
from -e:1:in `<main>'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
TracePoint. There's a few idiosyncrasies (especially with some tests) that're discussed in the review comments