Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the -W and --warnings options and support redefined parameterizing rules #448

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

ydah
Copy link
Collaborator

@ydah ydah commented Jun 18, 2024

This PR adds an option to output warnings and adds an option to warn when parameterizing rules are being redefined.
Specify -W or --warning option to output a warning about the redefinition of parameterizing rules.

Diagnostics:
    -W, --warnings         report the warnings

Motivation

Currently, for example, there is no way for users to know that the parameterizing rules provided by the standard library have been redefined.
Therefore, this support will allow users to know when parameterizing rules have been redefined.

@ydah ydah requested a review from yui-knk June 20, 2024 00:34
ydah added 3 commits June 26, 2024 23:30
Specify this category in the `-W` or `--warning` option to output a warning about the redefinition of parameterizing rules.

Currently, for example, users have no way of knowing the parameterizing rules provided in the standard library are redefined.
Therefore, by specifying the `parameterizing-redefined` option, users will be able to know parameterizing rules have been redefined.
@ydah ydah changed the title Introduce the -W and --warnings options and parameterizing-redefined category Introduce the -W and --warnings options and support redefined parameterizing rules Jun 26, 2024
@ydah ydah merged commit cac17e2 into ruby:master Jun 26, 2024
16 checks passed
@ydah ydah deleted the warn-option branch June 26, 2024 14:47
@yui-knk
Copy link
Collaborator

yui-knk commented Jun 29, 2024

I talked with @ydah in person on 6/25 (Wed). I agreed to add -W option and --warnings option, but I thought introducing the categories are premature because we are not sure about what categories are the best. We will introduce warning categories once we get feedback for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants