From f1523094dfdfecba839a728b66efbc3ddec25e01 Mon Sep 17 00:00:00 2001
From: S-H-GAMELINKS <gamelinks007@gmail.com>
Date: Sun, 2 Jun 2024 12:09:19 +0900
Subject: [PATCH] Rename Lrama::Grammar::Rule#to_s to
 Lrama::Grammar:Rule::display_name

---
 lib/lrama/command.rb                  | 2 +-
 lib/lrama/grammar.rb                  | 2 +-
 lib/lrama/grammar/code/rule_action.rb | 2 +-
 lib/lrama/grammar/rule.rb             | 5 ++---
 lib/lrama/states_reporter.rb          | 2 +-
 sig/lrama/grammar/rule.rbs            | 2 ++
 6 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/lib/lrama/command.rb b/lib/lrama/command.rb
index 12fc4fc7..ca34607f 100644
--- a/lib/lrama/command.rb
+++ b/lib/lrama/command.rb
@@ -44,7 +44,7 @@ def run(argv)
 
       if options.trace_opts && options.trace_opts[:rules]
         puts "Grammar rules:"
-        puts grammar.rules
+        grammar.rules.each { |rule| puts rule.display_name }
       end
 
       if options.trace_opts && options.trace_opts[:actions]
diff --git a/lib/lrama/grammar.rb b/lib/lrama/grammar.rb
index 02ebbb03..ba4b27fd 100644
--- a/lib/lrama/grammar.rb
+++ b/lib/lrama/grammar.rb
@@ -386,7 +386,7 @@ def validate_rule_lhs_is_nterm!
       rules.each do |rule|
         next if rule.lhs.nterm?
 
-        errors << "[BUG] LHS of #{rule} (line: #{rule.lineno}) is term. It should be nterm."
+        errors << "[BUG] LHS of #{rule.display_name} (line: #{rule.lineno}) is term. It should be nterm."
       end
 
       return if errors.empty?
diff --git a/lib/lrama/grammar/code/rule_action.rb b/lib/lrama/grammar/code/rule_action.rb
index 27db7044..572cfdc1 100644
--- a/lib/lrama/grammar/code/rule_action.rb
+++ b/lib/lrama/grammar/code/rule_action.rb
@@ -82,7 +82,7 @@ def lhs
         end
 
         def raise_tag_not_found_error(ref)
-          raise "Tag is not specified for '$#{ref.value}' in '#{@rule}'"
+          raise "Tag is not specified for '$#{ref.value}' in '#{@rule.display_name}'"
         end
       end
     end
diff --git a/lib/lrama/grammar/rule.rb b/lib/lrama/grammar/rule.rb
index 0e06edc8..23e6e553 100644
--- a/lib/lrama/grammar/rule.rb
+++ b/lib/lrama/grammar/rule.rb
@@ -16,8 +16,7 @@ def ==(other)
         self.lineno == other.lineno
       end
 
-      # TODO: Change this to display_name
-      def to_s
+      def display_name
         l = lhs.id.s_value
         r = empty_rule? ? "ε" : rhs.map {|r| r.id.s_value }.join(" ")
 
@@ -33,7 +32,7 @@ def as_comment
       end
 
       def with_actions
-        "#{to_s} {#{token_code&.s_value}}"
+        "#{display_name} {#{token_code&.s_value}}"
       end
 
       # opt_nl: ε     <-- empty_rule
diff --git a/lib/lrama/states_reporter.rb b/lib/lrama/states_reporter.rb
index 6f96cc6f..5197d30b 100644
--- a/lib/lrama/states_reporter.rb
+++ b/lib/lrama/states_reporter.rb
@@ -275,7 +275,7 @@ def report_states(io, itemsets, lookaheads, solved, counterexamples, verbose)
 
             a.each do |state_id2, nterm_id2|
               n = @states.nterms.find {|n| n.token_id == nterm_id2 }
-              io << "    (Rule: #{rule}) -> (State #{state_id2}, #{n.id.s_value})\n"
+              io << "    (Rule: #{rule.display_name}) -> (State #{state_id2}, #{n.id.s_value})\n"
             end
           end
           io << "\n"
diff --git a/sig/lrama/grammar/rule.rbs b/sig/lrama/grammar/rule.rbs
index 5a639022..81b01b3d 100644
--- a/sig/lrama/grammar/rule.rbs
+++ b/sig/lrama/grammar/rule.rbs
@@ -20,6 +20,8 @@ module Lrama
         ?precedence_sym: Lexer::Token?, ?lineno: Integer?
       ) -> void
 
+      def display_name: () -> String
+
       def as_comment: -> String
 
       def empty_rule?: -> bool