Make rake test run all tests under test/irb/ directory
#794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think `rake test` should run all tests under `test/irb/` directory without the need to update it every time we add a subdirectory under it. While this means tests under `test/irb/yamatanooroti` will be run too, without the vterm gem installed they will be skipped anyway.
st0012
requested review from
amatsuda and
a team
and removed request for
amatsuda
tompng
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just found that the newly added tests under
test/irb/cmd/were not run withrake test.I think
rake testshould run all tests undertest/irb/directory without the need to update it every time we add a subdirectory under it. While this means tests undertest/irb/yamatanoorotiwill be run too, without the vterm gem installed they will be skipped anyway.