Test debug commands without yamatanooroti #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can we possibly set up an irbrc on setup and remove it on teardown? I'm not sure if we want to add an interface only for tests. |
|
FWIW, it can also be used by users to make production setup easier: #351 (comment) Instead of:
User can set But it probably worth a separate discussion. I'll try using |
As discussed in ruby#449 (review), we should avoid adding new tests that need yamatanooroti because it's not maintained by the Ruby org. And since debug commands are now tested in `test/irb/test_debug_cmd.rb`, we don't need these tests anymore.
st0012
force-pushed
the
test-debug-commands
branch
from
c12a26c to
43114b6
Compare
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Dec 2, 2022
(ruby/irb#464) * Add debug command tests that don't require yamatanooroti * Remove debug command related yamatanooroti tests As discussed in ruby/irb#449 (review), we should avoid adding new tests that need yamatanooroti because it's not maintained by the Ruby org. And since debug commands are now tested in `test/irb/test_debug_cmd.rb`, we don't need these tests anymore. * Test against latest debug gem ruby/irb@78a8aa8834
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #449, it's better to not rely on
yamatanoorotifor new tests. So in this PR, I added debug command tests using approach similar todebug's (withpty) and removed the ones added in #449.Note: There seems to be an issue in
debug 1.6.3that causesdeleteto fail in Ruby 2.6~3.0 (example), but not 3.1+ (example). Given that it seems addressed in the latestdebug, we should test with this version until it's officially released.