Changing reviewing policy #266
pocke
announced in
Announcements
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hello everyone. Today I announce that I changed reviewing policy in this repository.
What is the new reviewing policy
I review only the following points of view:
_scripts/test
) looks valid.CODEOWNERS
updates to invite.It means I do NOT review the quality of RBS. It means this repository may include low-quality RBS files, but we accept them.
Background
Previously, I reviewed all PR deeply. I read gem's source code to confirm the added RBS is valid.
It is necessary to keep RBS files quality, but I had to spend a lot of time.
I spent half of my working hours for RBS, but I could not allocate time to develop RBS things due to too much reviewing. I wanted to reduce my reviewing time.
With this change, I just need to do a few reviewing (almost nothing). So I'll spend more time developing RBS things such as improving
rbs collection
and so on.Unfortunately RBS quality will be lower as a trade-off. We do not guarantee RBS quality except the CI does.
I'd like to reduce the impact, so I'll introduce some automation if there is any. I have introduced untyped call checking for this purpose, but I guess we can improve more things.
But I guess the quality will be lower even if we introduce automation. We should compromise it, and I hope the community improves the quality.
For other code owners
Code owners can review with policies of themselves. They should review the same points as me (except CODEOWNER changes), but they can additionally review other things. e.g. RBS quality.
Beta Was this translation helpful? Give feedback.
All reactions