Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#to_json(:lower_camel_case) generates camel cased keys #410

Merged
merged 3 commits into from
Jan 7, 2020
Merged

#to_json(:lower_camel_case) generates camel cased keys #410

merged 3 commits into from
Jan 7, 2020

Conversation

aslakhellesoy
Copy link

This is a fix for #408

I wasn't sure where to update the documentation - please let me know if you require more changes.

@film42
Copy link
Member

film42 commented Jan 7, 2020

Thanks for this PR! Don't worry about the 1.9.3 failure. We should probably drop 1.9.3 support.

@film42 film42 merged commit a84b39f into ruby-protobuf:3-10-stable Jan 7, 2020
@aslakhellesoy
Copy link
Author

Thanks for merging so quickly! I see you released 3.10.3, but CHANGES.md doesn't reflect it.

@aslakhellesoy aslakhellesoy deleted the lower-camel-case-field-names-json branch January 7, 2020 15:39
@film42
Copy link
Member

film42 commented Jan 7, 2020

Thanks for the reminder! Totally spaced. I'll update CHANGES once I merge my PR that updates travis and gets CI passing again.

@aslakhellesoy
Copy link
Author

I also believe you need to create a new 3-11-stable maintenance branch now eh? :-) Life as an open source contributor...

@aslakhellesoy aslakhellesoy mentioned this pull request Feb 4, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@film42 film42 film42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aslakhellesoy @film42