Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY up connection handling logic #224

Merged
merged 6 commits into from
Oct 27, 2015
Merged

DRY up connection handling logic #224

merged 6 commits into from
Oct 27, 2015

Commits on Oct 2, 2015

  1. DRY up connection handling logic

    Jeremy Bopp committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    d5f7516 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2015

  1. Move connection error handling logic into a new error class 

    * ConnectionError wraps the creation of several error types for backward compatibility
* For now, ConnectionError is only created when more than 1 error is given to the constructor
* In the future, ConnectionError should be used even in the single error case
    Jeremy Bopp committed Oct 18, 2015
    Configuration menu
    Copy the full SHA
    edee2ee View commit details
    Browse the repository at this point in the history

  2. Resolve rubocop violations

    Jeremy Bopp committed Oct 18, 2015
    Configuration menu
    Copy the full SHA
    e1a0d13 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2015

  1. Assign exceptions to a variable rather than use $!

    Jeremy Bopp committed Oct 19, 2015
    Configuration menu
    Copy the full SHA
    5a4ddb1 View commit details
    Browse the repository at this point in the history

  2. Close the socket where opened when necessary

    Jeremy Bopp committed Oct 19, 2015
    Configuration menu
    Copy the full SHA
    ab320af View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2015

  1. Move connection cleanup logic into the close method

    Jeremy Bopp committed Oct 26, 2015
    Configuration menu
    Copy the full SHA
    e829069 View commit details
    Browse the repository at this point in the history