Versioning ignores HTTP method, only matches on route name.

[coreystinson2]

When defining the same routes under different versions, the version 2 routes are not matching on the http method, it appears that they're only looking at the name.

class API < Grape::API

  version "v1", using: :accept_version_header

  get "/" do
    return "foo"
  end

  post "/" do
    return "bar"
  end

  version "v2", using: :accept_version_header

  get "/" do
    return "baz"
  end

  post "/" do
    return "qux"
  end

end

curl -X GET http://localhost:3000/
=> "foo"

curl -X POST http://localhost:3000/
=> "bar"

curl -X GET http://localhost:3000/ --header "Accept-Version:v2"
=> "qux"
# it is expected that this returns "baz"

curl -X POST http://localhost:3000/ --header "Accept-Version:v2"
=> "qux"

[coreystinson2]

Added a third DELETE route under the version2 definition and now GET and POST verbs are matching to this. It appears to be matching only to the last-defined route ?

delete "/" do
  return "quux"
end

[dblock]

This looks suspiciously simple for a bug, but Accept-Version is not widely used, so who knows. Try to see what specs we have for this and turn this one into a failing one?

[coreystinson2]

Sure, i'll take a look and see what I can find.
Is the default path strategy a more "preferred" method of achieving versioning with grape ?

[dblock]

I would say the HTTP way is :header, check out https://code.dblock.org/2013/07/19/evolving-apis-using-grape-api-versioning.html

[nickrivadeneira]

I opened #1799 which I believe to be related and contains some analysis and suggestions.