Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting :values range to enum #235

Closed
azhi opened this issue Mar 18, 2015 · 6 comments
Closed

Converting :values range to enum #235

azhi opened this issue Mar 18, 2015 · 6 comments

Comments

@azhi
Copy link
Contributor

azhi commented Mar 18, 2015

Exctacted from #233 and #234

Converting :values ranges to enums (arrays) in docs might not be the best idea.
It may lead to poor performance and huge JSON docs in case of large ranges.

I think the proper solution would be not to convert ranges to enums at all. However, this feature was in the release and some people might be using it.

Also we could try some dirty hack like convert to an array only if Range#size is less then some amount (say, 50). But that seems very odd to me.

@dblock
Copy link
Member

dblock commented Apr 7, 2015

This has been discussed and is definitely a problem, I'd appreciate a PR/fix.

@u2
Copy link
Contributor

u2 commented Apr 26, 2015

So, any good idea?

@u2
Copy link
Contributor

u2 commented Jun 3, 2015

#259

@vbalazs
Copy link

vbalazs commented Oct 7, 2016

@LeFnord can we close this issue? As far as I can see it has been fixed with the PR in the previous comment.

@LeFnord
Copy link
Member

LeFnord commented Oct 7, 2016

think yes, in the master (OAPI2.0) the implementation is similar
what did you think @dblock?

@dblock
Copy link
Member

dblock commented Oct 7, 2016

I have no opinions here, do your thing :)

@LeFnord LeFnord closed this as completed Oct 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants