From fa452a48d65f0128af0ffc2ea7a7c392b9f2cbc7 Mon Sep 17 00:00:00 2001 From: Benoit Daloze Date: Fri, 24 Feb 2023 18:42:23 +0100 Subject: [PATCH] Run isolated specs on the oldest CRuby too --- .github/workflows/ci.yml | 6 +++++- lib/concurrent-ruby/concurrent/atomic/locals.rb | 3 +-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0efb752a4..01be2df2b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -33,13 +33,17 @@ jobs: isolated: name: "Test isolated" runs-on: ubuntu-latest + strategy: + fail-fast: false + matrix: + ruby: [ 2.3, 3.2 ] # oldest and latest CRuby env: RUBYOPT: '-w' steps: - uses: actions/checkout@v3 - uses: ruby/setup-ruby@v1 with: - ruby-version: 3.2 + ruby-version: ${{ matrix.ruby }} bundler-cache: true - run: bundle exec rake compile - run: bundle exec rake spec:isolated diff --git a/lib/concurrent-ruby/concurrent/atomic/locals.rb b/lib/concurrent-ruby/concurrent/atomic/locals.rb index 86186dcbf..0a276aedd 100644 --- a/lib/concurrent-ruby/concurrent/atomic/locals.rb +++ b/lib/concurrent-ruby/concurrent/atomic/locals.rb @@ -1,8 +1,7 @@ +require 'fiber' require 'concurrent/utility/engine' require 'concurrent/constants' -require 'fiber' - module Concurrent # @!visibility private # @!macro internal_implementation_note