Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 358 - NAS Direct Archive support #555

Merged
merged 5 commits into from
Jan 27, 2020
Merged

Issue 358 - NAS Direct Archive support #555

merged 5 commits into from
Jan 27, 2020

Conversation

mwpreston
Copy link
Contributor

@mwpreston mwpreston commented Jan 27, 2020

Description

Added DirectArchive switch parameter and associated code to New-RubrikFileSet allowing the isPassthrough attribute to be set to enable NAS Direct Archive.

Related Issue

Addresses Issue 358

Motivation and Context

Allows customers to configure NAS Direct Archive when setting up filesets.

How Has This Been Tested?

  • Please describe in detail how you tested your changes.
  • Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc.

Tested in the TM lab.

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mwpreston mwpreston requested a review from shamsway January 27, 2020 14:40
Copy link
Contributor

@shamsway shamsway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, lgtm

@shamsway shamsway merged commit 9c33d70 into devel Jan 27, 2020
@shamsway shamsway deleted the mwpreston-358 branch January 27, 2020 21:01
@shamsway shamsway mentioned this pull request Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants