PF - Issue #283

[pfguglielmi]

Description

Code complete. This new cmdlet allows to update an existing SLA Domain with new settings. Advanced SLA configuration introduced in 5.0 is supported.

Related Issue

This project only accepts pull requests related to open issues.

• If suggesting a new feature or change, please discuss it in an issue first.
• If fixing a bug, there should be an issue describing it with steps to reproduce

Relates to issue #283

Motivation and Context

Why is this change required? What problem does it solve?
Updating an existing SLA Domain was not possible before.

How Has This Been Tested?

• Please describe in detail how you tested your changes.
• Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc.

I've done extensive tests against a 4.2 cluster and a 5.0 cluster, with and without advanced SLA configuration enabled. Tested all parameters for both CDM versions, whether all at once, or individually, or in pairs fro instance. Tested both with input from the pipeline (Get-RubrikSLA) and without. Tested with PowerShell Core as well as Windows PowerShell.

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTION document.
• I have updated the CHANGELOG file accordingly for the version that this merge modifies.
• I have added tests to cover my changes.
• All new and existing tests passed.

[jaapbrasser]

No code reviews required, PR created to facilitate collaboration on this PR

[jaapbrasser]

@pfguglielmi I have made some changes to allow for pipelining from Get-RubrikSLA. It is in working order but it might be able to use some improvements. Can you take a look at the code and let me know what you think.

Also can you verify that the validate set for HourlyRetentionUnit is correct?

[rfitzhugh]

Relates to issue #283

[mwpreston]

Looks great PF. I had no issues...

Other than I don't see any unit tests :)

Probably want to have another look at this though - lots of code there - good work!

[jaapbrasser]

Tested the Set-RubrikSLA command against multiple SLAs, Creating SLAs from scratch and modifying different properties of those SLAs. Seems to work as intended. There is a lot of logic in the if-elseif-else statements in this script. This needs a solid suite unit tests to ensure this works as intended, and to allow others to modify this code with confidence.