Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new cmdlet Update-RubrikVMwareVM #306

Merged
merged 7 commits into from
Jun 20, 2019

Conversation

pfguglielmi
Copy link
Contributor

Description

Added new cmdlet Update-RubrikVMwareVM

Related Issue

This project only accepts pull requests related to open issues.

  • If suggesting a new feature or change, please discuss it in an issue first.
  • If fixing a bug, there should be an issue describing it with steps to reproduce

[Issue 305(https://github.com//issues/305)]

Motivation and Context

Why is this change required? What problem does it solve?

Doing a full vCenter refresh can be time and resource intensive when managing a very large VMware environment.
Create a cmdlet to refresh a single VM's metadata using the following endpoint: /vmware/vcenter/{id}/refresh_vm

How Has This Been Tested?

  • Please describe in detail how you tested your changes.
  • Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc.

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rfitzhugh
Copy link
Contributor

Related to Add refresh_vm cmdlet #305

@jaapbrasser
Copy link
Contributor

Thanks for your contributions @pfguglielmi, I have added some additional documentation and started writing the Pester tests. Other than that the code looks solid and will be merged into the repository today!

Copy link
Contributor

@jaapbrasser jaapbrasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, added the unit tests to the branch and it is ready to be merged.

@jaapbrasser jaapbrasser self-assigned this Jun 20, 2019
@jaapbrasser jaapbrasser merged commit 7abc966 into rubrikinc:master Jun 20, 2019
@jaapbrasser
Copy link
Contributor

Resolve #306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants