Added DetailedObject parameter to Get-RubrikVM #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added an additional parameter -DetailedObject, If anyone has a suggestion for a different parameter name I would be happy to update it. The idea of the change is to prevent the unintuative approach of having to pipe Get-RubrikVM myvm01 into Get-RubrikVM in order to get full details. The switch parameter abstracts this away for the user to give consistent results. |
chriswahl
suggested changes
Mar 17, 2019
Rubrik/Public/Get-RubrikVM.ps1
Outdated
| @@ -27,6 +27,10 @@ function Get-RubrikVM | |||
| .EXAMPLE | |||
| Get-RubrikVM -Relic | |||
| This will return all removed virtual machines that were formerly protected by Rubrik. | |||
|
|
|||
| .EXAMPLE | |||
| Get-RubrikVM -id myserver01 -DetailedObject | |||
There was a problem hiding this comment.
I believe this example should use the Name param.
Get-RubrikVM -Name 'Server1' -DetailedObject
There was a problem hiding this comment.
Cool I updated the description and added a progress bar for DetailedObject queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Get-RubrikVM inconsistent results
Related Issue
#262
Please link to the issue here
Motivation and Context
Currently Get-RubrikVM -Name and Get-RubrikVM -id return different datasets, which can be confusing from a user perspective. I added the -DetailedObject parameter, to execute an additional query by ID to retrieve the full details on the computer object.
How Has This Been Tested?
I created an if-else statement that will execute a second query. I tested this code against the TM lab environment
Screenshots (if appropriate):
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!