Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include status codes and description in POST results which return nothing. #442

Closed
mwpreston opened this issue Sep 9, 2019 · 0 comments
Closed

Comments

@mwpreston
Copy link
Contributor

mwpreston commented Sep 9, 2019

Is your feature request related to a problem? Please describe.

For cmdlets which call DELETE methods and have empty results, the SDK currently will return the HTTP status code along with a status method (IE Remove-RubrikFileset). This same functionality isn't applied for cmdlets which remove objects and return nothing using the POST method (IE Remove-RubrikUnmanagedObject)

Describe the solution you'd like

Would like to see the cmdlets which have no returned result using the POST method also display the HTTPStatus Codes and STatus methods just as those that call DELETE methods do.

This would at least allow end users and customers to see that something did happen and whether it was successful or not. As well as give us something to test against with unit tests.

Would need to include POST methods as well as DELETE on the if statement on line 19 of Submit-Request.ps1

IE, changing
if ($resources.method -eq 'Delete') {
to
if ($resources.method -in ("Delete","Post") {

Describe alternatives you've considered

Additional context

Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants