Cop Idea: Repeated Description in Same Example Group

[backus]

This issue is very common: rubocop/rubocop#3816 (comment)

Basically, it is easy for people to bootstrap tests they write by copying the previous and forgetting to change the description string. We should consider flagging this if the repeated description is not inside a new context, description, shared_example, etc.

[backus]

@andyw8 @bquorning @dgollahon what do you think?

[andyw8]

I haven't run into this very often, but I see no problem with adding a check for it.

[dgollahon]

@backus: I think it's interesting and probably helpful for writing more descriptive tests. I wonder if it should be enabled by default or at what sensitivity though--It might be a little much to have every duplicate flagged by default. It would be interesting to see how many offenses you get on popular / large codebases.

[backus]

@dgollahon true. I'll try it on our private codebase and a few others I contribute to see how many false positives there are.

[andyw8]

If you can put on a branch, I can try running it on some repos too.

[backus]

@andyw8 see #259

[backus]

This cop found a few violations in rubocop-rspec that I fixed :)

[backus]

I ran this cop on rubocop's specs. I think rubocop/rubocop#3828 demonstrates that this cop is pretty helpful.

[backus]

Implemented in #259