Cop idea: Don’t stub when you’re mocking

[bquorning]

Sometimes, I see people defining a mock and tacking a stub onto the end it:

expect(foo).to receive(:bar).with(42).and_return("hello world")

subject.exercise

Now RSpec will expect foo to receive :bar with the argument 42.

If you read the code aloud, it very much sounds like "hello world" should also be part of the expectation. It isn’t.

I can think of at least two ways to rewrite this:

allow(foo).to receive(:bar).with(42).and_return("hello world")
expect(foo).to receive(:bar).with(42)

subject.exercise

or

allow(foo).to receive(:bar).with(42).and_return("hello world")

subject.exercise

expect(foo).to have_received(:bar).with(42)