Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuboCop::RSpec::Language::NodePattern was removed #1884

Closed
bquorning opened this issue May 19, 2024 · 4 comments
Closed

RuboCop::RSpec::Language::NodePattern was removed #1884

bquorning opened this issue May 19, 2024 · 4 comments
Milestone

Comments

@bquorning
Copy link
Collaborator

Address rubocop-rspec_rails still having a dependency on RuboCop::RSpec::Language::NodePattern which we removed in d841fe4. We should probably fix this before next release.

@bquorning bquorning added this to the 3.0 milestone May 19, 2024
@bquorning
Copy link
Collaborator Author

cc @ydah

@pirj
Copy link
Member

pirj commented May 19, 2024

We would also need to bump the dependency to the fixed rubocop-rspec_rails version?

@bquorning
Copy link
Collaborator Author

bquorning commented May 19, 2024

We (rubocop-rspec) don’t have a runtime dependency on rubocop-rspec_rails anymore.

It seems that the issue in rubocop-rspec_rails is easy enough to fix – we can just remove the line with the require. But it needs to be on a version of rubocop-rspec which includes d841fe4, which has not been released yet.

We can probably make a v3.0.0.pre quite soon, which would make it possible to at least open a PR on rubocop-rspec_rails.

Update: Here’s the PR.

@bquorning
Copy link
Collaborator Author

I think rubocop/rubocop-rspec_rails#30 proves this issue is easily solvable. I’m closing this so it doesn’t block v3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants