From 0dfddaf67a19df479ba0ff24ffe6af8277db18d0 Mon Sep 17 00:00:00 2001 From: Earlopain <14981592+Earlopain@users.noreply.github.com> Date: Sat, 3 Aug 2024 11:22:57 +0200 Subject: [PATCH] Remove `Range#minmax` refinement It was added for a bug in Ruby <= 2.7 The minimum version now is 2.7 so it is not needed anymore. https://github.com/rubocop/rubocop-ast/pull/151 ``` irb(main):001:0> RUBY_VERSION => "2.6.10" irb(main):002:0> Range.instance_method(:minmax).owner != ::Range => true irb(main):002> RUBY_VERSION => "2.7.8" irb(main):003> Range.instance_method(:minmax).owner != ::Range => false ``` --- lib/rubocop/ast.rb | 1 - lib/rubocop/ast/ext/range_min_max.rb | 18 ------------------ lib/rubocop/ast/node_pattern/node.rb | 1 - 3 files changed, 20 deletions(-) delete mode 100644 lib/rubocop/ast/ext/range_min_max.rb diff --git a/lib/rubocop/ast.rb b/lib/rubocop/ast.rb index fee3d5f23..59ec61ea5 100644 --- a/lib/rubocop/ast.rb +++ b/lib/rubocop/ast.rb @@ -5,7 +5,6 @@ require 'set' require_relative 'ast/ext/range' -require_relative 'ast/ext/range_min_max' require_relative 'ast/node_pattern/method_definer' require_relative 'ast/node_pattern' require_relative 'ast/node/mixin/descendence' diff --git a/lib/rubocop/ast/ext/range_min_max.rb b/lib/rubocop/ast/ext/range_min_max.rb deleted file mode 100644 index 08e2d322c..000000000 --- a/lib/rubocop/ast/ext/range_min_max.rb +++ /dev/null @@ -1,18 +0,0 @@ -# frozen_string_literal: true - -module RuboCop - module AST - module Ext - # Refinement to circumvent broken `Range#minmax` for infinity ranges in 2.6- - module RangeMinMax - if ::Range.instance_method(:minmax).owner != ::Range - refine ::Range do - def minmax - [min, max] - end - end - end - end - end - end -end diff --git a/lib/rubocop/ast/node_pattern/node.rb b/lib/rubocop/ast/node_pattern/node.rb index b02af25a9..d98709fcb 100644 --- a/lib/rubocop/ast/node_pattern/node.rb +++ b/lib/rubocop/ast/node_pattern/node.rb @@ -7,7 +7,6 @@ class NodePattern class Node < ::Parser::AST::Node extend Forwardable include ::RuboCop::AST::Descendence - using Ext::RangeMinMax MATCHES_WITHIN_SET = %i[symbol number string].to_set.freeze private_constant :MATCHES_WITHIN_SET