Merge pull request #6679 from rmm5t/fix-lint-disjunctive-assignment-i…

…n-constructor-for-empty-constructors

[Fix #6678] Allow empty constructors during Lint/DisjunctiveAssignmentInConstructor

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## master (unreleased)
 
+### Bug fixes
+
+* [#6678](https://github.com/rubocop-hq/rubocop/issues/6678): Fix `Lint/DisjunctiveAssignmentInConstructor` when it finds an empty constructor. ([@rmm5t][])
+
 ## 0.63.0 (2019-01-16)
 
 ### New features
@@ -3758,3 +3762,4 @@
 [@Intrepidd]: https://github.com/Intrepidd
 [@Ruffeng]: https://github.com/Ruffeng
 [@roooodcastro]: https://github.com/roooodcastro
+[@rmm5t]: https://github.com/rmm5t

lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb

@@ -34,12 +34,13 @@ def on_def(node)
         def check(node)
           return unless node.method_name == :initialize
 
-          check_body(node)
+          check_body(node.body)
         end
 
         # @param [DefNode] node a constructor definition
-        def check_body(node)
-          body = node.body
+        def check_body(body)
+          return if body.nil?
+
           case body.type
           when :begin
             check_body_lines(body.child_nodes)

spec/rubocop/cop/lint/disjunctive_assignment_in_constructor_spec.rb

@@ -6,6 +6,17 @@
 ) do
   subject(:cop) { described_class.new(config) }
 
+  context 'empty constructor' do
+    it 'accepts' do
+      expect_no_offenses(<<-RUBY.strip_indent)
+        class Banana
+          def initialize
+          end
+        end
+      RUBY
+    end
+  end
+
   context 'constructor does not have disjunctive assignment' do
     it 'accepts' do
       expect_no_offenses(<<-RUBY.strip_indent)