Improve a bit the code style in Rails/RelativeDateConstant

rubocop · Apr 3, 2017 · 2dc72ae · 2dc72ae
1 parent 212f68b
commit 2dc72ae
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/rubocop/cop/rails/relative_date_constant.rb b/lib/rubocop/cop/rails/relative_date_constant.rb
@@ -25,17 +25,19 @@ class RelativeDateConstant < Cop
         RELATIVE_DATE_METHODS = %i[ago from_now since until].freeze
 
         def on_casgn(node)
-          return if node.children.last.lambda_or_proc?
+          _scope, _constant, rhs = *node
 
-          bad_node = node.descendants.find { |n| bad_method?(n) }
+          return if rhs.lambda_or_proc?
+
+          bad_node = node.descendants.find { |n| relative_date_method?(n) }
           return unless bad_node
 
           add_offense(node, :expression, format(MSG, bad_node.method_name))
         end
 
         private
 
-        def bad_method?(node)
+        def relative_date_method?(node)
           node.send_type? &&
             RELATIVE_DATE_METHODS.include?(node.method_name) &&
             node.method_args.empty?