Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-po fails to work with PO files from languages ending with the character n #5

Open
sanderhouttekier opened this issue Oct 31, 2013 · 5 comments

Comments

@sanderhouttekier
Copy link
Contributor

Just to give you a heads-up,

I created an issue on node-po's issue tracker requesting info on why he replaces the final n character when parsing headers.

this renders using english po files useless unless you manually replace the language string in the compiled angular translations.js. from eundefined into en

see the issue here: mikejholly/node-po#7
however being the 7th issue in the 1 year of that repositories live, and none of the previous being closed or implemented, I doubt it will ever be picked up.

@rubenv
Copy link
Owner

rubenv commented Oct 31, 2013

Thanks for the heads up.

Sounds like it's time to fork it then!

@sanderhouttekier
Copy link
Contributor Author

I shouted too early, pull request accepted, no need for a fork.

@rubenv
Copy link
Owner

rubenv commented Oct 31, 2013

Great, will bump dependency when there's a new release of node-po.

@demetriusnunes
Copy link

Ruben, for some reason, setting the dependency on a specific git revision is making npm install fail on Windows machines.

@rubenv
Copy link
Owner

rubenv commented Dec 3, 2013

@demetriusnunes Which versions of Node and NPM? And unless you provide some info on what "making npm install fail" means, there's no way for me to be able to help you out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants