Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about clearing Set-Cookie behaviour #170

Open
DawidJanczak opened this issue Sep 22, 2020 · 1 comment
Open

Question about clearing Set-Cookie behaviour #170

DawidJanczak opened this issue Sep 22, 2020 · 1 comment

Comments

@DawidJanczak
Copy link

Hello!

I have a question about the behaviour surrounding clearing the Set-Cookie header introduced here #52 From what I saw when testing this, cookies of any middleware inserted after rack cache in the middleware stack (including the app itself) indeed get cleared, but cookies set by middleware coming before rack cache are not. Is this intentional?

@grosser
Copy link
Collaborator

grosser commented Sep 25, 2020

bast ask @rmm5t ... but good lock with that 8 year old change :)
afaik it was meant to not cache the Set-Cookie header, if it still does that when the header was set before the middleware (as in returns the header from the cache on a subsequent request) then we need a new fix :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants