Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known Issue: Connector dependencies fail to build for Node 18.20, 20.12 and 21.6 #198

Closed
Alxe opened this issue Apr 9, 2024 · 1 comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@Alxe
Copy link
Member

Alxe commented Apr 9, 2024

Due to a change in upstream Node, a Connector dependency fails to build. This change was first instroduced in Node 21.6 and later backported to Node 18.20 and Node 20.12.

The error trace contains at the very least the following:

node-addon-api/napi-inl.h:65:47: error: invalid conversion from ‘napi_finalize’ {aka ‘void (*)(napi_env__*, void*, void*)’} to ‘node_api_nogc_finalize’ {aka ‘void (*)(const napi_env__*, void*, void*)’} [-fpermissive]
@alexcamposruiz
Copy link
Collaborator

After the migration to koffi this issue is fixed in develop and will be included in a future release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants