Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cortex-m-semihosting requirement from 0.3.3 to 0.5.0 #680

Merged
merged 6 commits into from
Jan 14, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 3, 2023

Updates the requirements on cortex-m-semihosting to permit the latest version.

Changelog

Sourced from cortex-m-semihosting's changelog.

[v0.5.0] - 2018-05-11

Added

  • DebugMonitor and SecureFault variants to the Exception enumeration.

  • An optional "inline-asm" feature

Changed

  • [breaking-change] This crate now requires arm-none-eabi-gcc to be installed and available in $PATH when built with the "inline-asm" feature disabled (which is disabled by default).

  • [breaking-change] The register::{apsr,lr,pc} modules are now behind the "inline-asm" feature.

  • [breaking-change] Some variants of the Exception enumeration are no longer available on thumbv6m-none-eabi. See API docs for details.

  • [breaking-change] Several of the variants of the Exception enumeration have been renamed to match the CMSIS specification.

  • [breaking-change] fixed typo in shcrs field of scb::RegisterBlock; it was previously named shpcrs.

  • [breaking-change] removed several fields from scb::RegisterBlock on ARMv6-M. These registers are not available on that sub-architecture.

  • [breaking-change] changed the type of scb::RegisterBlock.shpr from RW<u8> to RW<u32> on ARMv6-M. These registers are word accessible only on that sub-architecture.

  • [breaking-change] renamed the mmar field of scb::RegisterBlock to mmfar to match the CMSIS name.

  • [breaking-change] removed the iabr field from scb::RegisterBlock on ARMv6-M. This register is not available on that sub-architecture.

  • [breaking-change] removed several fields from cpuid::RegisterBlock on ARMv6-M. These registers are not available on that sub-architecture.

  • [breaking-change] The Mutex.new constructor is not a const fn by default. To make it a const fn you have to opt into the "const-fn" feature, which was added in v0.5.1, and switch to a nightly compiler.

Removed

  • [breaking-change] The exception module has been removed. A replacement for Exception::active can be found in SCB::vect_active. A modified version exception::Exception can be found in the peripheral::scb module.

[v0.4.3] - 2018-01-25

... (truncated)

Commits
  • a448e91 v0.5.0
  • e3217ad Merge #88
  • 05bbc3b always list all the peripherals in Peripherals
  • 550f949 fix build for ARMv7E-M + "inline-asm"
  • 7d51707 simplify #[cfg]s
  • 2cd6092 ARMv6-M: remove fields that are not available from cpuid::RegisterBlock
  • 17bd0c8 fix x86_64 tests
  • c290aa4 ARMv6-M: remove fields that are not available from NVIC and SCB
  • 716398c fix build on ARMv6-M
  • 1d68643 fix build on ARMv7E-M
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [cortex-m-semihosting](https://github.com/rust-embedded/cortex-m) to permit the latest version.
- [Release notes](https://github.com/rust-embedded/cortex-m/releases)
- [Changelog](https://github.com/rust-embedded/cortex-m/blob/master/CHANGELOG.md)
- [Commits](rust-embedded/cortex-m@c-m-sh-v0.3.5...v0.5.0)

---
updated-dependencies:
- dependency-name: cortex-m-semihosting
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Jan 3, 2023
@AfoHT AfoHT added the skip-changelog Sometimes changes are not significant enough for a changelog entry label Jan 3, 2023
AfoHT
AfoHT previously approved these changes Jan 3, 2023
Copy link
Contributor

@AfoHT AfoHT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Should be fine as it is just a dev-dep. All the cool kids use RTT or anything but semihosting...

bors bot added a commit that referenced this pull request Jan 3, 2023
680: Update cortex-m-semihosting requirement from 0.3.3 to 0.5.0 r=AfoHT a=dependabot[bot]

Updates the requirements on [cortex-m-semihosting](https://github.com/rust-embedded/cortex-m) to permit the latest version.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/rust-embedded/cortex-m/blob/master/CHANGELOG.md">cortex-m-semihosting's changelog</a>.</em></p>
<blockquote>
<h2>[v0.5.0] - 2018-05-11</h2>
<h3>Added</h3>
<ul>
<li>
<p><code>DebugMonitor</code> and <code>SecureFault</code> variants to the <code>Exception</code> enumeration.</p>
</li>
<li>
<p>An optional <code>&quot;inline-asm&quot;</code> feature</p>
</li>
</ul>
<h3>Changed</h3>
<ul>
<li>
<p>[breaking-change] This crate now requires <code>arm-none-eabi-gcc</code> to be installed and available in
<code>$PATH</code> when built with the <code>&quot;inline-asm&quot;</code> feature disabled (which is disabled by default).</p>
</li>
<li>
<p>[breaking-change] The <code>register::{apsr,lr,pc}</code> modules are now behind the <code>&quot;inline-asm&quot;</code> feature.</p>
</li>
<li>
<p>[breaking-change] Some variants of the <code>Exception</code> enumeration are no longer available on
<code>thumbv6m-none-eabi</code>. See API docs for details.</p>
</li>
<li>
<p>[breaking-change] Several of the variants of the <code>Exception</code> enumeration have been renamed to
match the CMSIS specification.</p>
</li>
<li>
<p>[breaking-change] fixed typo in <code>shcrs</code> field of <code>scb::RegisterBlock</code>; it was previously named
<code>shpcrs</code>.</p>
</li>
<li>
<p>[breaking-change] removed several fields from <code>scb::RegisterBlock</code> on ARMv6-M. These registers are
not available on that sub-architecture.</p>
</li>
<li>
<p>[breaking-change] changed the type of <code>scb::RegisterBlock.shpr</code> from <code>RW&lt;u8&gt;</code> to <code>RW&lt;u32&gt;</code> on
ARMv6-M. These registers are word accessible only on that sub-architecture.</p>
</li>
<li>
<p>[breaking-change] renamed the <code>mmar</code> field of <code>scb::RegisterBlock</code> to <code>mmfar</code> to match the CMSIS
name.</p>
</li>
<li>
<p>[breaking-change] removed the <code>iabr</code> field from <code>scb::RegisterBlock</code> on ARMv6-M. This register is
not available on that sub-architecture.</p>
</li>
<li>
<p>[breaking-change] removed several fields from <code>cpuid::RegisterBlock</code> on ARMv6-M. These registers
are not available on that sub-architecture.</p>
</li>
<li>
<p>[breaking-change] The <code>Mutex.new</code> constructor is not a <code>const fn</code> by default. To make it a <code>const fn</code> you have to opt into the <code>&quot;const-fn&quot;</code> feature, which was added in v0.5.1, and switch to a
nightly compiler.</p>
</li>
</ul>
<h3>Removed</h3>
<ul>
<li>[breaking-change] The <code>exception</code> module has been removed. A replacement for <code>Exception::active</code>
can be found in <code>SCB::vect_active</code>. A modified version <code>exception::Exception</code> can be found in the
<code>peripheral::scb</code> module.</li>
</ul>
<h2>[v0.4.3] - 2018-01-25</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/rust-embedded/cortex-m/commit/a448e9156e2cb1e556e5441fd65426952ef4b927"><code>a448e91</code></a> v0.5.0</li>
<li><a href="https://github.com/rust-embedded/cortex-m/commit/e3217ad94d6c941796c2d7ee8735e7b250a69387"><code>e3217ad</code></a> Merge <a href="https://github-redirect.dependabot.com/rust-embedded/cortex-m/issues/88">#88</a></li>
<li><a href="https://github.com/rust-embedded/cortex-m/commit/05bbc3b815703a0654d2e37966547e392f856161"><code>05bbc3b</code></a> always list all the peripherals in <code>Peripherals</code></li>
<li><a href="https://github.com/rust-embedded/cortex-m/commit/550f94902fc1f84241c200b5af02a2cc369a56d1"><code>550f949</code></a> fix build for ARMv7E-M + &quot;inline-asm&quot;</li>
<li><a href="https://github.com/rust-embedded/cortex-m/commit/7d51707b5f1b19c148ec4c21decd83abcdf7b2ca"><code>7d51707</code></a> simplify #[cfg]s</li>
<li><a href="https://github.com/rust-embedded/cortex-m/commit/2cd6092848cfa35ab64fce7ccf87e52402fc41e6"><code>2cd6092</code></a> ARMv6-M: remove fields that are not available from cpuid::RegisterBlock</li>
<li><a href="https://github.com/rust-embedded/cortex-m/commit/17bd0c8e88e1bbd036f940df80e8d047a46025e1"><code>17bd0c8</code></a> fix x86_64 tests</li>
<li><a href="https://github.com/rust-embedded/cortex-m/commit/c290aa4ee89951a0ea503b129f6c5bd3d47a663d"><code>c290aa4</code></a> ARMv6-M: remove fields that are not available from NVIC and SCB</li>
<li><a href="https://github.com/rust-embedded/cortex-m/commit/716398ce542798aff238abc6a978d3b64a1c0dd4"><code>716398c</code></a> fix build on ARMv6-M</li>
<li><a href="https://github.com/rust-embedded/cortex-m/commit/1d6864377202bc64e522deeb5dd044e593d83ebb"><code>1d68643</code></a> fix build on ARMv7E-M</li>
<li>Additional commits viewable in <a href="https://github.com/rust-embedded/cortex-m/compare/c-m-sh-v0.3.5...v0.5.0">compare view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

681: Update os_pipe requirement from 0.9.2 to 1.1.2 r=AfoHT a=dependabot[bot]

Updates the requirements on [os_pipe](https://github.com/oconnor663/os_pipe.rs) to permit the latest version.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/oconnor663/os_pipe.rs/commit/9ea8c6af47611a92e6ac398e2375a8cc9c872b69"><code>9ea8c6a</code></a> version 1.1.2</li>
<li><a href="https://github.com/oconnor663/os_pipe.rs/commit/3bacd8a41677feaa401c744a31a71eb4b18114aa"><code>3bacd8a</code></a> Switch from winapi to windows-sys</li>
<li><a href="https://github.com/oconnor663/os_pipe.rs/commit/4950ad9b195410caacba58e6158b67c6d0035140"><code>4950ad9</code></a> version 1.1.1</li>
<li><a href="https://github.com/oconnor663/os_pipe.rs/commit/d88d838c47242ae8c5f46dc2ebf5ac01ac1a9d7e"><code>d88d838</code></a> fix a paste-o in Cargo.toml</li>
<li><a href="https://github.com/oconnor663/os_pipe.rs/commit/3d658ffd0811d1081e7dfceb5f0b18493eec6a7f"><code>3d658ff</code></a> version 1.1.0</li>
<li><a href="https://github.com/oconnor663/os_pipe.rs/commit/a2c22371963378a75456e121d62b1df95ac37644"><code>a2c2237</code></a> document the io_safety feature</li>
<li><a href="https://github.com/oconnor663/os_pipe.rs/commit/4aca11ee4b40f21742fa49797e3d3d0307dc099a"><code>4aca11e</code></a> cargo fmt</li>
<li><a href="https://github.com/oconnor663/os_pipe.rs/commit/5fd66fab227d953512e3e18c2ffeaa58fed0e1b8"><code>5fd66fa</code></a> implement I/O safety traits</li>
<li><a href="https://github.com/oconnor663/os_pipe.rs/commit/f41c58e503e1efc5e4d0edfcd2e756b3a81b4232"><code>f41c58e</code></a> version 1.0.1</li>
<li><a href="https://github.com/oconnor663/os_pipe.rs/commit/df536487aec9634d4f5397c40361d2a4e5297fda"><code>df53648</code></a> add a TODO</li>
<li>Additional commits viewable in <a href="https://github.com/oconnor663/os_pipe.rs/compare/0.9.2...1.1.2">compare view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Jan 3, 2023

Build failed (retrying...):

bors bot added a commit that referenced this pull request Jan 3, 2023
680: Update cortex-m-semihosting requirement from 0.3.3 to 0.5.0 r=AfoHT a=dependabot[bot]

Updates the requirements on [cortex-m-semihosting](https://github.com/rust-embedded/cortex-m) to permit the latest version.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/rust-embedded/cortex-m/blob/master/CHANGELOG.md">cortex-m-semihosting's changelog</a>.</em></p>
<blockquote>
<h2>[v0.5.0] - 2018-05-11</h2>
<h3>Added</h3>
<ul>
<li>
<p><code>DebugMonitor</code> and <code>SecureFault</code> variants to the <code>Exception</code> enumeration.</p>
</li>
<li>
<p>An optional <code>&quot;inline-asm&quot;</code> feature</p>
</li>
</ul>
<h3>Changed</h3>
<ul>
<li>
<p>[breaking-change] This crate now requires <code>arm-none-eabi-gcc</code> to be installed and available in
<code>$PATH</code> when built with the <code>&quot;inline-asm&quot;</code> feature disabled (which is disabled by default).</p>
</li>
<li>
<p>[breaking-change] The <code>register::{apsr,lr,pc}</code> modules are now behind the <code>&quot;inline-asm&quot;</code> feature.</p>
</li>
<li>
<p>[breaking-change] Some variants of the <code>Exception</code> enumeration are no longer available on
<code>thumbv6m-none-eabi</code>. See API docs for details.</p>
</li>
<li>
<p>[breaking-change] Several of the variants of the <code>Exception</code> enumeration have been renamed to
match the CMSIS specification.</p>
</li>
<li>
<p>[breaking-change] fixed typo in <code>shcrs</code> field of <code>scb::RegisterBlock</code>; it was previously named
<code>shpcrs</code>.</p>
</li>
<li>
<p>[breaking-change] removed several fields from <code>scb::RegisterBlock</code> on ARMv6-M. These registers are
not available on that sub-architecture.</p>
</li>
<li>
<p>[breaking-change] changed the type of <code>scb::RegisterBlock.shpr</code> from <code>RW&lt;u8&gt;</code> to <code>RW&lt;u32&gt;</code> on
ARMv6-M. These registers are word accessible only on that sub-architecture.</p>
</li>
<li>
<p>[breaking-change] renamed the <code>mmar</code> field of <code>scb::RegisterBlock</code> to <code>mmfar</code> to match the CMSIS
name.</p>
</li>
<li>
<p>[breaking-change] removed the <code>iabr</code> field from <code>scb::RegisterBlock</code> on ARMv6-M. This register is
not available on that sub-architecture.</p>
</li>
<li>
<p>[breaking-change] removed several fields from <code>cpuid::RegisterBlock</code> on ARMv6-M. These registers
are not available on that sub-architecture.</p>
</li>
<li>
<p>[breaking-change] The <code>Mutex.new</code> constructor is not a <code>const fn</code> by default. To make it a <code>const fn</code> you have to opt into the <code>&quot;const-fn&quot;</code> feature, which was added in v0.5.1, and switch to a
nightly compiler.</p>
</li>
</ul>
<h3>Removed</h3>
<ul>
<li>[breaking-change] The <code>exception</code> module has been removed. A replacement for <code>Exception::active</code>
can be found in <code>SCB::vect_active</code>. A modified version <code>exception::Exception</code> can be found in the
<code>peripheral::scb</code> module.</li>
</ul>
<h2>[v0.4.3] - 2018-01-25</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/rust-embedded/cortex-m/commit/a448e9156e2cb1e556e5441fd65426952ef4b927"><code>a448e91</code></a> v0.5.0</li>
<li><a href="https://github.com/rust-embedded/cortex-m/commit/e3217ad94d6c941796c2d7ee8735e7b250a69387"><code>e3217ad</code></a> Merge <a href="https://github-redirect.dependabot.com/rust-embedded/cortex-m/issues/88">#88</a></li>
<li><a href="https://github.com/rust-embedded/cortex-m/commit/05bbc3b815703a0654d2e37966547e392f856161"><code>05bbc3b</code></a> always list all the peripherals in <code>Peripherals</code></li>
<li><a href="https://github.com/rust-embedded/cortex-m/commit/550f94902fc1f84241c200b5af02a2cc369a56d1"><code>550f949</code></a> fix build for ARMv7E-M + &quot;inline-asm&quot;</li>
<li><a href="https://github.com/rust-embedded/cortex-m/commit/7d51707b5f1b19c148ec4c21decd83abcdf7b2ca"><code>7d51707</code></a> simplify #[cfg]s</li>
<li><a href="https://github.com/rust-embedded/cortex-m/commit/2cd6092848cfa35ab64fce7ccf87e52402fc41e6"><code>2cd6092</code></a> ARMv6-M: remove fields that are not available from cpuid::RegisterBlock</li>
<li><a href="https://github.com/rust-embedded/cortex-m/commit/17bd0c8e88e1bbd036f940df80e8d047a46025e1"><code>17bd0c8</code></a> fix x86_64 tests</li>
<li><a href="https://github.com/rust-embedded/cortex-m/commit/c290aa4ee89951a0ea503b129f6c5bd3d47a663d"><code>c290aa4</code></a> ARMv6-M: remove fields that are not available from NVIC and SCB</li>
<li><a href="https://github.com/rust-embedded/cortex-m/commit/716398ce542798aff238abc6a978d3b64a1c0dd4"><code>716398c</code></a> fix build on ARMv6-M</li>
<li><a href="https://github.com/rust-embedded/cortex-m/commit/1d6864377202bc64e522deeb5dd044e593d83ebb"><code>1d68643</code></a> fix build on ARMv7E-M</li>
<li>Additional commits viewable in <a href="https://github.com/rust-embedded/cortex-m/compare/c-m-sh-v0.3.5...v0.5.0">compare view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Jan 3, 2023

Build failed:

@korken89
Copy link
Collaborator

korken89 commented Jan 5, 2023

It requires removing all .unwrap() on hprintln!() calls

sd 'hprintln(.*).unwrap\(\)' 'hprintln' (fd -e rs .)
sd 'hprintln(.*).ok\(\)' 'hprintln' (fd -e rs .)
@AfoHT AfoHT force-pushed the dependabot/cargo/cortex-m-semihosting-0.5.0 branch from 00a06bf to 050313d Compare January 11, 2023 21:17
New semihosting 0.5 does not use error handling,
returns directly and as semihosting is generally slow
this led to missing print statements.

Workaround is to add NOP, which seems sufficient
to let it flush the buffers
@AfoHT
Copy link
Contributor

AfoHT commented Jan 14, 2023

As discussed, the newer cortex-m-semihosting, which now does not return possible errors on each print invocation, changed the timing behaviour slightly.

As the semihosting printouts are slow, they do not get sent out in case debug::exit(debug::EXIT_SUCCESS); // Exit QEMU simulator happened directly after.

Previously this was not an issue and seems the error handling ensured they did get printed.

@AfoHT AfoHT removed the skip-changelog Sometimes changes are not significant enough for a changelog entry label Jan 14, 2023
Copy link
Contributor

@AfoHT AfoHT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 14, 2023

Build succeeded:

  • ci

@bors bors bot merged commit 86ce891 into master Jan 14, 2023
@bors bors bot deleted the dependabot/cargo/cortex-m-semihosting-0.5.0 branch January 14, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants