Add changelog for the next release #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lydell
commented
Jan 16, 2021
| @@ -6,6 +6,38 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/). | |||
| This project mirrors major Elm versions. So version 0.18.\* of this project will | |||
| be compatible with Elm 0.18.\*. | |||
|
|
|||
| ## 0.19.1-beta1.revision5 - 2020-TBA | |||
There was a problem hiding this comment.
Note that according to the semver module:
0.19.1-beta1.revision5 < 0.19.1-revision5
0.19.1-revision5.beta1 > 0.19.1-revision5
What I’m trying to say is that we need to be careful when choosing the suffix so tools like ncu/npm-upgrade don’t think that the beta is a later version than the final revision5.
There was a problem hiding this comment.
Lets not do a beta release. I think the quality is pretty good, I have been using the master with no issues.
harrysarson
approved these changes
Jan 28, 2021
| @@ -6,6 +6,38 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/). | |||
| This project mirrors major Elm versions. So version 0.18.\* of this project will | |||
| be compatible with Elm 0.18.\*. | |||
|
|
|||
| ## 0.19.1-beta1.revision5 - 2020-TBA | |||
There was a problem hiding this comment.
Lets not do a beta release. I think the quality is pretty good, I have been using the master with no issues.
|
Feel free to change the version and date when doing the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #468
@harrysarson Feel free to close this PR you’d rather write the changelog yourself. I’m sure it can be used as inspiration/a checklist at least! Also feel free to push directly to this branch if you want to tweak something – or do a regular review on GitHub. Whatever you feel like.
Random note:
When releasing, we need to:
versionin package.json and package-lock.json.npm publish --tag beta.--tag betais important, so that we only update ourbetatag and notlatest. Runnpm dist-tag elm-testto see our current tags: