-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elm-test --watch crashes if Elm code doesn't compile #399
Comments
Update! It used to crash like this:
Since #448 it exits like this:
So:
|
harrysarson
pushed a commit
that referenced
this issue
Oct 16, 2020
Fixes #399. Previously, if there was an error in src/ for a package project, elm-test --watch would immediately exit. This was because we compile src/ first to get .elmi files for the files in there so that elmi-to-json can find the exact dependencies there. But since #451 we don’t use elmi-to-json to find exact dependencies anymore – we use elm-json instead – so there’s no need for that compilation step anymore. I removed that, which fixes the issue and also improves test run time since the compiler is invoked one time less. As for the undefined log issue, that was because of promises being rejected with strings while the .catch code expected Error objects. "some string".message is undefined, so that’s where it came from. I updated to reject with Error objects instead. This allowed for some pretty nice cleanups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce:
yarn test
in terminalNode version: v10.16.0
OS: MacOS
Elm version: 0.19.1
The text was updated successfully, but these errors were encountered: