Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requiring elmi-to-json is slow on Windows #385

Closed
showell opened this issue Oct 1, 2019 · 8 comments
Closed

requiring elmi-to-json is slow on Windows #385

showell opened this issue Oct 1, 2019 · 8 comments

Comments

@showell
Copy link

showell commented Oct 1, 2019

Even if I just run elm-test --help, it take 3.5s on my relatively powerful Windows laptop to run that in a git bash shell.

I am not sure what I'm doing wrong, or if elm-test is just heavy like that.

If there isn't any easy way to speed this up, could it at least be documented as a known issue in the readme?

@showell showell changed the title elm-test is slow to statup up (3+ seconds) elm-test is slow to start up (3+ seconds) Oct 1, 2019
@showell
Copy link
Author

showell commented Oct 10, 2019

This line is particularly slow (930ms on a fast, healthy Windows laptop with a current version of node):

var readElmiPath = require('elmi-to-json').paths['elmi-to-json'];

@showell showell changed the title elm-test is slow to start up (3+ seconds) requiring elmi-to-json is slow on Windows Oct 11, 2019
@razzeee
Copy link

razzeee commented Oct 14, 2019

Updating elmi-to-json to the latest version 1.2.0 should presumably help with this https://github.com/stoeffel/elmi-to-json/releases

But I can't get the tests to pass after that.

@razzeee
Copy link

razzeee commented Oct 25, 2019

Was done in 7ac6505 and should be in the next release

@rtfeldman
Copy link
Owner

@showell are you still seeing this in the current release, or can we close this?

@showell
Copy link
Author

showell commented Nov 11, 2019

My issues were never resolved. There's a thread here: https://elmlang.slack.com/archives/C0CLGCMMF/p1573296606141400

We figured out that it was Windows-specific issues.

@lydell
Copy link
Collaborator

lydell commented Oct 4, 2020

@showell Would you mind trying out #442 and see if it’s faster for you?

You can install with npm i -D lydell/node-test-runner#js.

Note that the duration in elm-test’s output is just for the test execution, not the compilation before that.

@showell
Copy link
Author

showell commented Oct 6, 2020

@lydell Sorry I can't help--I haven't been active in Elm lately, due to my day job.

@harrysarson
Copy link
Collaborator

I am happy to close this now. We no longer require elmi-to-json (on any OS which includes windows) so it cannot be slow. If anyone has any perf issues with the new approach (not yet released, will be version 0.19.1-revison5) please open a new issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants