-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for APIv2 #4274
Conversation
- This is a pure docs PR, no code changes - Move internal class API to "developer-interface" folder - Move APIv1 into a folder and add APIv2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think instead of moving the developer API, we should probably remove it for now. I don't believe it's being heavily used, and moving it will mean we just need to move it again once we rebuild it properly. It doesn't even document half the code currently, so I think having it there and half complete is worse than not there at all.
docs/api/v2.rst
Outdated
Largely this endpoint should be used only to get the Project ID | ||
which is used in other API calls. | ||
|
||
.. http:get:: /api/v2/search/project/?q={query} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should document this. It's not meant to be a public API, and it will be changing in our search upgrade GSOC project (#4265)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's no way to get the project ID in APIv2 then the API can't really be used for projects. Is there a better way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what I'll do is just remove this call. Perhaps a nice addition (in another PR) would be to add filtering that would allow searching based on a few fields (notably ?slug=
) so people can get the ID of their project.
Sounds good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm curious if we'll get any pushback around removing the API docs, if so that's good signaling that we should create better ones. I'd much prefer to spend the time writing words documenting the actual code instead, but that's much harder :)
I wonder if we should open an issue to capture latent pushback. We don't know what people don't complain about, and leaving a space for that may help us capture sentiment better. |
@RichardLitt Makes sense. I'll open one. |
I created this redirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already merged but I want to say that I loved your work :)
developer-interface/
folder in the docs.Fixes #1175
Note
After merging, we should add a redirect from
/api.html
->/api/v1.html
.