Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default sphinx version #4250

Merged
merged 4 commits into from
Jun 19, 2018
Merged

Update default sphinx version #4250

merged 4 commits into from
Jun 19, 2018

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jun 15, 2018 •
edited
Loading

@stsewd stsewd requested a review from a team June 15, 2018 18:22
@ericholscher
Copy link
Member

ericholscher commented Jun 18, 2018 •
edited
Loading

I wonder if we should just do <1.8?

@humitos
Copy link
Member

humitos commented Jun 18, 2018

I'd like to have <1.8 but "you never know". Anyway, maybe instead of increasing the version when it breaks for some reason, we could decrease (or pin) when it breaks.

👍 on using <1.8

ericholscher
ericholscher reviewed Jun 18, 2018
View reviewed changes
readthedocs/rtd_tests/tests/test_doc_building.py Outdated
@@ -1152,7 +1152,7 @@ def test_install_core_requirements_sphinx(self):
requirements_sphinx = [
'commonmark==0.5.4',
'recommonmark==0.4.0',
'sphinx==1.7.5',
'sphinx<1.8',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like we shouldn't be checking for this in a test, as it makes it really brittle. Should we remove this test?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at it more, it looks like we should be checking for what we actually care about (eg. 'sphinx' in called_arguments not "check it called the exact versions from our code"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, should I change all the tests here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I think it's a small enough change to be fine.

@ericholscher ericholscher merged commit af22d27 into readthedocs:master Jun 19, 2018
@ericholscher
Copy link
Member

👍

@stsewd stsewd deleted the update-sphinx-version-1.7.5 branch June 19, 2018 12:02
@buhtz buhtz mentioned this pull request Jun 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

autoclass not working, but no warnings or errors in log
3 participants
@stsewd @ericholscher @humitos