projects: serve badge with same protocol as site #4228
Conversation
|
I like this change. Thanks! Could you write a test for this, please? There are other similar tests in the |
|
@humitos let's make a deal, you hook some coverage to the CI and I'll write tests if the code i am touching is not tested :) |
readthedocs/projects/views/public.py
Outdated
| @@ -90,7 +90,8 @@ def get_context_data(self, **kwargs): | |||
| user=self.request.user, project=project) | |||
|
|
|||
| protocol = 'http' | |||
| if self.request.is_secure(): | |||
| use_https = getattr(settings, 'PUBLIC_DOMAIN_USES_HTTPS', False) | |||
There was a problem hiding this comment.
For this purpose, public domain != production domain. Badges are served from our production domain, docs are served from our public domain.
There was a problem hiding this comment.
So what about removing the scheme altogether?
Instead of request.is_secure use a schemaless url for the badge url in project detail view.
|
I've pushed the schema-less version |
xrmx
changed the title
|
This looks like a much better fix. I like protocol relative URL's 👍 |
|
Without a protocol users can't copy/paste the badge generated code anymore #4337 |
|
Feel free to revert then until we found a solution that work. |
Instead of request.is_secure use settings.PUBLIC_DOMAIN_USES_HTTPS
to find out if we should serve the badge under https or not.
That matches what the resolver is doing and works here.