-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move parser tests from rtd-build repo #4225
Conversation
👍 Yeah, so far so good. Is it easier to move this code over in parts like this, or to do all of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far looking good. We can either merge this PR now or attach more parts of readthedocs_build.config
to this PR before merge. I'll leave this up to @stsewd which approach to take.
I think is fine like this. But I'll attach another little part here ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I move this file, and the encoding problem was gone. I think the issue was the file having a bad encoding when created. See readthedocs/readthedocs-build#45 and #3732 (comment)
Probably the file was corrupted, the test pass with a proper unicode filename. See readthedocs#3732 (comment)
This is done, I'm leaving |
We are using unicode literals
I forgot about the unicode literals 😞 in the previous commit. Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'm not sure if I'm doing this in the proper way, hopefully it's a start.