-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed breaking change in pip 10.0.0b1 (2018-03-31) #4206
Fixed breaking change in pip 10.0.0b1 (2018-03-31) #4206
Conversation
FlorianKuckelkorn
commented
Jun 7, 2018
- Fixed breaking change in pip 10.0.0b1 (2018-03-31)
- "--use-wheel" was removed fro pip's cli
- "--use-wheel" was removed fro pip's cli
Thanks! can you link to the changelog? Also, rtd isn't using pip10 right now, it uses this docker images https://github.com/rtfd/readthedocs-docker-images |
Hi, that's my very first pull request on github :) |
Just put it in this issue. My second comment was about that rtd doesn't use pip10 yet, and for doing it, we need to update all the docker images from our side. So, probably this PR would be blocked till we update the pip version, or maybe both options can live together? (changelog is helpful here) |
Ok i got it ;) Probably if we remove line complety it would work for all pip versions, i would guess... |
Blocking this till we update pip |
This flag was introduced in pip7 https://pip.pypa.io/en/stable/news/#id25, so it's not blocked, we can merge this. Also, this fixes #4238 |
👍 |
Thanks! |
Revert "Merge pull request #4206 from FlorianKuckelkorn/fix/pip-breaking-change"