Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing gitignore item for ES testing #4193

Merged
merged 1 commit into from
Jun 6, 2018
Merged

Conversation

ericholscher
Copy link
Member

No description provided.

Verified

This commit was signed with the committer’s verified signature.
davidfischer David Fischer
@ericholscher ericholscher requested a review from safwanrahman June 6, 2018 19:01
@safwanrahman
Copy link
Member

have you run the script locally?

@ericholscher
Copy link
Member Author

Yea, I ran it to get ES setup on the same version to test against :)

Copy link
Member

@safwanrahman safwanrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool! I had never run the script locally so could not catch this.
r+

@safwanrahman safwanrahman merged commit 9dbb768 into master Jun 6, 2018
@stsewd stsewd deleted the add-ignore branch August 15, 2018 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants