-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small footer rework #4150
Small footer rework #4150
Conversation
The CI errors are unrelated. |
I like this in general, a few comments:
A proposal:
I'm also not sold on keeping "Donate" around, now that we have real business things, it feels a bit disjoint. I think we should probably focus on where we want people to go (eg. less Commercial Support, more Private Hosting) |
I liked what you did, David and I agree with Eric about how to organize the content. Those 3 headings are clearer regarding what you a looking for. Also, there are some changes like "Commercial Support" to "Private Hosting" that makes a difference to me. Not sure about removing the "Donate" menu. I would keep it there, it doesn't force anybody to Donate, but if you feel like, you can find it there. The other way to find it is under your Admin settings in the Gold section: there is a link to |
I like the icons but I'm willing to be overruled. I do think a github icon and a twitter icon is better than the word "GitHub" or "Twitter". It also gives us space to grow if we do more social media stuff although I don't think that's very important.
I'm willing to drop it. Overall, I think the proposed organization makes sense. |
Debatably "Team" should go under "Business Info". Also possibly "Business Info" should be simply "Business". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel strongly enough about the social icons to veto them, so I'm happy with this direction.
</li> | ||
</ul> | ||
|
||
<p>{% trans 'Sign up for our newsletter to get our latest blog updates delivered to your inbox weekly.' %}</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might also link the blog
here to the blog, and perhaps even more it from above. That might make it a bit more seemless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like these changes. Too much clear and simplified from my point of view.
Regarding the icons, either way works to me.
This reworks the footer specifically to:
From a browser perspective, I tested this down to IE11.
SCREENSHOT