Allow import Gitlab repo manually and set a webhook automatically #3934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
force-pushed
the
humitos/webhook/manual-import-gitlab
branch
from
93c0aae to
573120e
Compare
ericholscher
approved these changes
Apr 18, 2018
Yes. They are working because they always used the Then, because of that decision we found this issue. |
agjohnson
requested changes
Apr 19, 2018
readthedocs/oauth/services/gitlab.py
Outdated
| repo_id = '{username}%2F{repo}'.format( | ||
| username=username, | ||
| repo=repo, | ||
| ) |
There was a problem hiding this comment.
This needs error handling and probably some tests. In a case where get_gitlab_username_repo doesn't match, it returns (None, None) and we'll search for repo 'None/None'.
When we import a Project manually we don't have a RemoteRepository associated with that Project, so we use the old technique of getting the username and repo names from the URL using `get_gitlab_username_repo` function. This case (Manual Import) won't support custom Gitlab installations in the future with this code.
humitos
force-pushed
the
humitos/webhook/manual-import-gitlab
branch
from
573120e to
844b6a9
Compare
|
I just added a test case for this and rebased the branch. |
agjohnson
approved these changes
May 3, 2018
|
Changes and test look good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we import a Project manually we don't have a RemoteRepository associated with that Project, so we use the old technique of getting the username and repo names from the URL using
get_gitlab_username_repofunction.This case (Manual Import) won't support custom Gitlab installations in the future with this code.
Closes https://github.com/readthedocs/readthedocs-corporate/issues/265