Fixup DJANGO_SETTINGS_SKIP_LOCAL in tests #3899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The import path for the local_settings should be relative to the test module and not absolute otherwise the import will fail.
|
What was the error that you were receiving without this patch? How I can reproduce it? |
|
Just add some options in local_settings.py, run the tests and you see they are ignored. In my case i've added a DATABASES entry, removed DJANGO_SETTINGS_SKIP_LOCAL=False from tox.ini and run tox. |
|
And also |
|
Friendly ping, this is a really trivial issue :) |
|
This looks fine, as it mimics |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import path for the local_settings should be relative to the
test module and not absolute otherwise the import will fail.