Remove pinned CSS Select version #3813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
approved these changes
Mar 16, 2018
|
I think this one can be merged. |
|
I merged master in to fix the tests so I can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSSSelect is not invoked directly but instead used by PyQuery. After upgrading PyQuery in #2916 the new version now requires a newer version of CSSSelect.
If we want to be super explicit, we should specify the version of CSSSelect right next to where we specify PyQuery rather than in a separate file. The separate file was particularly bad because a different version of CSSSelect ran in testing vs production/deploy.