Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update machine field when activating a version from project_version_detail #3797

Closed
wants to merge 1 commit into from
Closed

Update machine field when activating a version from project_version_detail #3797

wants to merge 1 commit into from

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Mar 14, 2018

agjohnson
agjohnson requested changes Mar 16, 2018
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the underlying issue here? This is the wrong place to set that the version is machine created -- a version isn't created at this point.

@agjohnson agjohnson added PR: work in progress Pull request is not ready for full review Needed: more information A reply from issue author is required and removed PR: ready for review labels Mar 16, 2018
@xrmx
Copy link
Contributor Author

xrmx commented Mar 16, 2018

@agjohnson I found this hunk in our instance. If it's wrong let's just close this.

@xrmx xrmx closed this Mar 16, 2018
@xrmx xrmx deleted the project_version_detail_set_machine branch June 13, 2018 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson requested changes

Assignees
No one assigned
Labels
Needed: more information A reply from issue author is required PR: work in progress Pull request is not ready for full review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrmx @agjohnson @RichardLitt