Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for build notifications #3654

Merged
merged 2 commits into from
Feb 22, 2018
Merged

Tests for build notifications #3654

merged 2 commits into from
Feb 22, 2018

Conversation

humitos
Copy link
Member

@humitos humitos commented Feb 22, 2018

Add test and fixes bug introduced in #3653

@humitos humitos requested a review from agjohnson February 22, 2018 20:59
agjohnson
agjohnson approved these changes Feb 22, 2018
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agjohnson agjohnson merged commit e9d0d2f into master Feb 22, 2018
@agjohnson agjohnson deleted the humitos/email/notification-tests branch February 22, 2018 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humitos @agjohnson