Hack in a fix for missing version slug deploy that went out a while back #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
reviewed
Dec 21, 2017
| @@ -75,6 +75,10 @@ def footer_html(request): | |||
| subproject = request.GET.get('subproject', False) | |||
| source_suffix = request.GET.get('source_suffix', '.rst') | |||
|
|
|||
| # Hack in a fix for missing version slug deploy that went out a while back | |||
| if version_slug == '': | |||
| version_slug = 'latest' | |||
There was a problem hiding this comment.
Maybe this is better,
if not version_slug:
version_slug = LATEST
The "linting" guy :)
There was a problem hiding this comment.
We actually want to check it being an empty string, not None, because that is the error I'm catching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also has some updates to
symlinkcommand, so we can properly rebuild web05 without running out of memory.