Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove copyright application #3400

Merged
merged 1 commit into from
Dec 14, 2017
Merged

Remove copyright application #3400

merged 1 commit into from
Dec 14, 2017

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Dec 14, 2017

This PR closes #3199

@stsewd
Copy link
Member Author

stsewd commented Dec 14, 2017

Travis is falling for the same reason on master

https://github.com/rtfd/readthedocs.org/blob/1a053bdf358b29494a81055885029cfb7c60bf43/readthedocs/restapi/views/footer_views.py#L46

There is any PR on the way to solve this? So I can rebase.

@agjohnson
Copy link
Contributor

agjohnson commented Dec 14, 2017 •
edited
Loading

Oops, yeah looks like an PR wasn't wrapped up completely. I just submitted #3402 to address the lint error. Feel free to cherry-pick or rebase there.

agjohnson
agjohnson approved these changes Dec 14, 2017
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I think we can just merge this and when #3402 is merged, the lint error will be resolved.

@agjohnson agjohnson merged commit 4373cba into readthedocs:master Dec 14, 2017
@stsewd stsewd deleted the remove-copyright-application branch December 14, 2017 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove copyright application
2 participants
@stsewd @agjohnson