Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mkdocs search. #3361

Merged
merged 1 commit into from
Dec 5, 2017
Merged

Fix mkdocs search. #3361

merged 1 commit into from
Dec 5, 2017

Conversation

ericholscher
Copy link
Member

The mkdocs search builder was not passing its return code back up,
which meant search=False,
which means that the JSON files weren't syncing or being indexed.

@ericholscher ericholscher requested a review from humitos December 5, 2017 16:41
humitos
humitos approved these changes Dec 5, 2017
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! :)

@agjohnson agjohnson merged commit d7736e1 into master Dec 5, 2017
@agjohnson agjohnson deleted the fix-mkdocs-search branch December 5, 2017 23:19
This was referenced Apr 3, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericholscher @humitos @agjohnson