Try and get folks to put more tags. #3350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
force-pushed
the
better-tags
branch
from
39b8f83 to
91c6387
Compare
humitos
reviewed
Dec 4, 2017
| <h3>{% trans "Tags" %}</h3> | ||
| <p> | ||
| {% if project.tags.count %} | ||
| {% for tag in project.tags.all %} | ||
| <a href="{% url "projects_tag_detail" tag.slug %}">{{ tag.name }}</a>{% if forloop.last %}{% else %}, {% endif %} | ||
| {% empty %} | ||
| <span class="quiet">{% trans "No tags" %}</span> |
There was a problem hiding this comment.
This condition won't be met since it has to be 0 on project.tags.count to have an empty list. I think you can remove the empty block.
| {% for tag in project.tags.all %} | ||
| <a href="{% url "projects_tag_detail" tag.slug %}">{{ tag.name }}</a>{% if forloop.last %}{% else %}, {% endif %} | ||
| {% empty %} | ||
| <span class="quiet">{% trans "No tags" %}</span> | ||
| {% endfor %} | ||
| </p> | ||
| {% else %} | ||
| Project has no tags. |
| {% else %} | ||
| Project has no tags. | ||
| {% if request.user|is_admin:project %} | ||
| Add some in your <a href="{% url 'projects_edit' project.slug %}">project settings</a>. |
|
!m @humitos |
humitos
approved these changes
Dec 5, 2017
| {% trans "Project has no tags." %} | ||
| {% if request.user|is_admin:project %} | ||
|
|
||
| {% url 'projects_edit' project.slug as edit_url %} |
There was a problem hiding this comment.
I don't remember this exactly but, can we just use the url tag like this to create a local variable? don't we need the with tag for this?
There was a problem hiding this comment.
| <span class="quiet">{% trans "No tags" %}</span> | ||
| {% endfor %} | ||
|
|
||
| {% if project.tags.count %} |
There was a problem hiding this comment.
I saw that we are using .count in some places where we don't need the number but we want to know the existence. So, maybe it's better to use .exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.