-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest wiping your environment to folks with bad build outcomes. #3347
Conversation
This is a basic start to trying to be more helpful to users.
I like the idea of giving some tips/advice on the "why this build has failed?". I would like to start testing something simple like this, how it goes, and maybe later try to make it "more intelligent" but I wouldn't spend more time on the intelligence at the moment but maybe more tips. |
Aye. I think we could build some nicer styles, and have easier ways for users to contribute them (eg. a YAML file of possible errors). But this is a nice start. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat feature, I like the pattern. Minor template issues were noted, copy and changes look good otherwise
{% block title %}Wipe the build directories for a version {% endblock %} | ||
|
||
{% block content %} | ||
|
||
{% blocktrans with slug=version.slug %} | ||
<h3>Remove build environment for <em>{{ slug }}</em> version.</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove the h3 at least from the blocktrans
|
||
<form method="post" action="#"> | ||
<input type="submit" value="Wipe version"> | ||
<input type="submit" value="Wipe {{ version.slug }}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-translated copy here
{% url 'projects_advanced' build.version.project.slug as advanced_url %} | ||
{% blocktrans %} | ||
Don't want <pre>setup.py install</pre> called? | ||
Change the <strong>Install Project</strong> setting in your <a href="{{ advanced_url }}">advanced settings</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
advanced_url
should be in the blocktrans
variable list
{% url 'wipe_version' build.version.project.slug build.version.slug as wipe_url %} | ||
{% blocktrans %} | ||
Having trouble with your build environment? | ||
Try <a href="{{ wipe_url }}">reseting it</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wipe_url
should be in the blocktrans variable list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how the docs say to do it. https://docs.djangoproject.com/en/1.9/topics/i18n/translation/#blocktrans-template-tag
{% if deleted %} | ||
Your project environment has been wiped.<br><br> | ||
{% blocktrans %} | ||
Your project environment has been wiped.<br><br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All <br>
can be removed. Spacing should be forced with a surrounding p
element, or other css.
This is a basic start to trying to be more helpful to users.