Change stable version switching to respect active
#3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This previously used the `machine` tag that was turned off when a user de-activated the version, but never turned back on when they re-activated it. This changes to just use the `active` flag on the Version, so we will update the stable version if the existing one is `active`, and not if it isn't, which makes _way_ more sense.
|
I think we should probably just kill the whole |
humitos
approved these changes
Nov 30, 2017
ericholscher
force-pushed
the
use-active-for-stable
branch
from
c71b635 to
01abd43
Compare
ericholscher
added a commit
that referenced
this pull request
Dec 7, 2017
Revert "Merge pull request #3336 from rtfd/use-active-for-stable"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This previously used the
machinetag that was turned off when a user de-activated the version,but never turned back on when they re-activated it.
This changes to just use the
activeflag on the Version,so we will update the stable version if the existing one is
active,and not if it isn't,
which makes way more sense.
Refs #3268