Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't delete the subprojects directory on sync of superproject #3042

Merged
merged 4 commits into from
Dec 7, 2017

Conversation

ericholscher
Copy link
Member

No description provided.

@ericholscher ericholscher added the PR: hotfix Pull request applied as hotfix to release label Aug 11, 2017
@ericholscher ericholscher requested a review from agjohnson August 30, 2017 20:38
@ericholscher
Copy link
Member Author

@agjohnson should get this merged, since I believe I already hotfixed it, or remove it.

@agjohnson
Copy link
Contributor

Needs lint fix still. I believe we discussed this already, but I'm not certain this actually addressed the issue with subproject removal entirely. I think this at least does something though, so we should merge after the lint fixes.

@ericholscher ericholscher merged commit 6a18b75 into master Dec 7, 2017
@RichardLitt RichardLitt deleted the exclude-projects branch December 7, 2017 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants