Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stable build process appears to pick up correct commit, but publishes a stale one #2563

Closed
evildmp opened this issue Dec 23, 2016 · 12 comments
Closed

Comments

@evildmp
Copy link
Contributor

evildmp commented Dec 23, 2016

Details

Expected Result

Stable should build the latest release; in fact it correctly (as you can see from the Build URL above) identifies the 845c5fdd3deed0ead7cc0b7bd19062ceaa8a9589 commit, django-cms/django-cms@845c5fd.

I'd expect http://docs.django-cms.org/en/stable/ to link reflect that commit and link back to it.

Actual Result

Instead, http://docs.django-cms.org/en/stable/ seems to be based on 25da45d5d1cd0f48e9e273e23c9a33343addeea4, a commit that doesn't actually exist (or maybe no longer exists) in the repository: https://github.com/divio/django-cms/edit/25da45d5d1cd0f48e9e273e23c9a33343addeea4/docs/index.rst.

We've wiped, deactivated, rebuilt the version, but to no avail.

Many thanks for your time.

@schollii
Copy link

I believe my issue is same: the https://readthedocs.org/projects/pypubsub/versions/ page shows 4 versions, including "stable" which indicates that it points to origin/v4.0.0. However if I click on the stable link, the docs shown are those of the old release, v3.3.0. I tried wipiing, did not help.

@Peque
Copy link

Peque commented Apr 2, 2017

I even tried removing the project from readthedocs.org and recreating it. No luck either. 😅

The easiest way to reproduce the error is:

  1. Go to a stable version of your documentation.
  2. Click on "Edit on GitHub" (top-right) to get a 404 error.

@jkroes
Copy link

jkroes commented Aug 31, 2017

I've got this problem too. Refreshing the url displays the new docs, but viewing the docs always take me to the old home page. It's a glaring issue because the only change I made was to switch Sphinx themes.

@Peque
Copy link

Peque commented Sep 5, 2017

It seems it is using a valid hash, although it is not the commit hash, but the release (tag) hash. Try to execute git rev-parse <latest_stable_release_tag> and see how you get the hash that readthedocs is currently using. You can also actually git checkout <that_hash> with no errors, to verify the reference exists.

Unfortunately, the readthedocs-generated GitHub URL that points to the original source code is invalid. To verify this simply go to the "stable" version of the documentation and click on "Edit on GitHub" on the top-right to see the broken link.

@ericholscher Wouldn't it be better to use the actual latest stable tag name when linking to the original source code rather than any hash? It is definitely more readable and would work just as well. Notice that old stable releases all point to the human-readable tag name (i.e.: mayor.minor.patch version), the latest version points to a readable name as well (i.e.: master branch), but only the stable version points to a non-readable hash (i.e.: ugly abcdef0123456789...).

Even though I think changing it to use the more readable tag name is better, if that is not possible, at least it could be great to change it so use the commit hash rather than the release hash, simply to avoid broken links (GitHub would recognize the commit hash reference as opposed to the release hash reference).

@Wrzlprmft
Copy link

Wrzlprmft commented Jan 11, 2018

Another case of this, unless I am mistaken:

http://jitcode.readthedocs.io/en/stable/ points to a very old release (0.1), though the building process indicates that it builds 1.1.0 (the correct stable version).

@RichardLitt RichardLitt added the Bug A bug label Jan 11, 2018
@stsewd
Copy link
Member

stsewd commented Jan 12, 2018

@Wrzlprmft I don't see in your version list http://readthedocs.org/projects/jitcode/versions/ the stable version. Did you deactivate it?

@Wrzlprmft
Copy link

@stsewd I protected it so it doesn’t appear in version lists and mislead people. The direct link should still work.

@stsewd
Copy link
Member

stsewd commented Jan 12, 2018

Also on http://docs.django-cms.org/en/release-3.4.x/ the edit on GitHub is invalid, because rtd renames the branch release/3.4.x to release-3.4.x

@stsewd
Copy link
Member

stsewd commented Jan 12, 2018

@Wrzlprmft the build url you give says it is the latest version, no the stable one.

@Wrzlprmft
Copy link

@stsewd: Indeed, my mistake. Fixed it in the above.

@Peque
Copy link

Peque commented Jan 22, 2018

Cross-linking #3142. In case anybody wants to try it.

@stsewd
Copy link
Member

stsewd commented May 21, 2018

Closing this as duplicate of #1820. The issue is with annotated tags. #4052 fix this.

@stsewd stsewd closed this as completed May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants